Commit d796c52e authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: make sure the journal sb is written in ext4_clear_journal_err() 



After we transfer set the EXT4_ERROR_FS bit in the file system
superblock, it's not enough to call jbd2_journal_clear_err() to clear
the error indication from journal superblock --- we need to call
jbd2_journal_update_sb_errno() as well.  Otherwise, when the root file
system is mounted read-only, the journal is replayed, and the error
indicator is transferred to the superblock --- but the s_errno field
in the jbd2 superblock is left set (since although we cleared it in
memory, we never flushed it out to disk).

This can end up confusing e2fsck.  We should make e2fsck more robust
in this case, but the kernel shouldn't be leaving things in this
confused state, either.

Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
parent 0d7614f0

fs/ext4/super.c

+1 −0
Original line number Diff line number Diff line
@@ -4430,6 +4430,7 @@ static void ext4_clear_journal_err(struct super_block *sb, 
		ext4_commit_super(sb, 1);



		jbd2_journal_clear_err(journal);

		jbd2_journal_update_sb_errno(journal);

	}

}

fs/jbd2/journal.c

+2 −1
Original line number Diff line number Diff line
@@ -1377,7 +1377,7 @@ static void jbd2_mark_journal_empty(journal_t *journal) 
 * Update a journal's errno.  Write updated superblock to disk waiting for IO

 * to complete.

 */

static void jbd2_journal_update_sb_errno(journal_t *journal)

void jbd2_journal_update_sb_errno(journal_t *journal)

{

	journal_superblock_t *sb = journal->j_superblock;
@@ -1390,6 +1390,7 @@ static void jbd2_journal_update_sb_errno(journal_t *journal) 


	jbd2_write_superblock(journal, WRITE_SYNC);

}

EXPORT_SYMBOL(jbd2_journal_update_sb_errno);



/*

 * Read the superblock for a given journal, performing initial

include/linux/jbd2.h

+1 −0
Original line number Diff line number Diff line
@@ -1125,6 +1125,7 @@ extern int jbd2_journal_destroy (journal_t *); 
extern int	   jbd2_journal_recover    (journal_t *journal);

extern int	   jbd2_journal_wipe       (journal_t *, int);

extern int	   jbd2_journal_skip_recovery	(journal_t *);

extern void	   jbd2_journal_update_sb_errno(journal_t *);

extern void	   jbd2_journal_update_sb_log_tail	(journal_t *, tid_t,

				unsigned long, int);

extern void	   __jbd2_journal_abort_hard	(journal_t *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE