Commit 7e5d6cf3 authored Jan 17, 2020 by Borislav Petkov

EDAC/amd64: Do not warn when removing instances



On machines which do not populate all nodes with DIMMs, the driver
doesn't initialize an instance there. However, the instance removal
remove_one_instance() path will warn unconditionally, which is wrong.

Remove the WARN_ON() even if the warning is innocent because it causes a
splat in dmesg.

Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200117115939.5524-1-bp@alien8.de

parent 6cd18453

drivers/edac/amd64_edac.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -3573,9 +3573,6 @@ static void remove_one_instance(unsigned int nid)
		struct mem_ctl_info *mci;
		struct amd64_pvt *pvt;

		mci = find_mci_by_dev(&F3->dev);
		WARN_ON(!mci);

		/* Remove from EDAC CORE tracking list */
		mci = edac_mc_del_mc(&F3->dev);
		if (!mci)

Admin message