Commit 6cd18453 authored Jan 15, 2020 by Wei Yongjun Committed by Borislav Petkov Jan 17, 2020

EDAC/sifive: Fix return value check in ecc_register()



In case of error, the function edac_device_alloc_ctl_info() returns a
NULL pointer, not ERR_PTR(). Replace the IS_ERR() test in the return
value check with a NULL test.

Fixes: 91abaeaa ("EDAC/sifive: Add EDAC platform driver for SiFive SoCs")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200115150303.112627-1-weiyongjun1@huawei.com

parent a651c6c6

drivers/edac/sifive_edac.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -54,8 +54,8 @@ static int ecc_register(struct platform_device *pdev)
		p->dci = edac_device_alloc_ctl_info(0, "sifive_ecc", 1, "sifive_ecc",
		1, 1, NULL, 0,
		edac_device_alloc_index());
		if (IS_ERR(p->dci))
		return PTR_ERR(p->dci);
		if (!p->dci)
		return -ENOMEM;

		p->dci->dev = &pdev->dev;
		p->dci->mod_name = "Sifive ECC Manager";

Admin message