Commit 7e35eab9 authored Jun 27, 2018 by Chengguang Xu Committed by David Sterba Aug 06, 2018

btrfs: replace empty string with NULL when getting attribute length in btrfs_get_acl



In btrfs_get_acl() the first call of btr_getxattr() is for getting the
length of attribute, the value buffer is never used in this case. So
it's better to replace empty string with NULL.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent ab3629ed

fs/btrfs/acl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -33,7 +33,7 @@ struct posix_acl btrfs_get_acl(struct inode inode, int type)
		return ERR_PTR(-EINVAL);
		}

		size = btrfs_getxattr(inode, name, "", 0);
		size = btrfs_getxattr(inode, name, NULL, 0);
		if (size > 0) {
		value = kzalloc(size, GFP_KERNEL);
		if (!value)

Admin message