Commit ab3629ed authored Jun 27, 2018 by Chengguang Xu Committed by David Sterba Aug 06, 2018

btrfs: return error instead of crash when detecting unexpected type in btrfs_get_acl



The caller of btrfs_get_acl() checks error condition so there is no
impact from this change. In practice there is no chance to get into
default case of switch statement because VFS has already checked the
type.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent af431dcb

fs/btrfs/acl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -30,7 +30,7 @@ struct posix_acl btrfs_get_acl(struct inode inode, int type)
		name = XATTR_NAME_POSIX_ACL_DEFAULT;
		break;
		default:
		BUG();
		return ERR_PTR(-EINVAL);
		}

		size = btrfs_getxattr(inode, name, "", 0);

Admin message