Commit 7e33f385 authored Aug 29, 2018 by Rob Herring Committed by Greg Kroah-Hartman Sep 10, 2018

staging: mt7621-pci: remove unnecessary check of device_type == pci



PCI host drivers have already matched on compatible strings, so checking
device_type is redundant. Also, device_type is considered deprecated for
FDT though we've still been requiring it for PCI hosts as it is useful
for finding PCI buses.

Cc: devel@driverdev.osuosl.org
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 13b72b08

drivers/staging/mt7621-pci/pci-mt7621.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -387,15 +387,8 @@ static int mt7621_pcie_parse_dt(struct mt7621_pcie *pcie)
		struct device *dev = pcie->dev;
		struct device_node *node = dev->of_node;
		struct resource regs;
		const char *type;
		int err;

		type = of_get_property(node, "device_type", NULL);
		if (!type \|\| strcmp(type, "pci") != 0) {
		dev_err(dev, "invalid \"device_type\" %s\n", type);
		return -EINVAL;
		}

		err = of_address_to_resource(node, 0, &regs);
		if (err) {
		dev_err(dev, "missing \"reg\" property\n");

Admin message