Commit 13b72b08 authored by Ioana Radulescu's avatar Ioana Radulescu Committed by Greg Kroah-Hartman
Browse files

staging: fsl-dpaa2/ethsw: Fix uninitialized variables 



Functions port_vlans_add() and port_vlans_del() could,
in theory, return an uninitialized variable. Fix this
by initializing the variable in question at declaration.

Signed-off-by: default avatarIoana Radulescu <ruxandra.radulescu@nxp.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b972c798

drivers/staging/fsl-dpaa2/ethsw/ethsw.c

+2 −2
Original line number Diff line number Diff line
@@ -717,7 +717,7 @@ static int port_vlans_add(struct net_device *netdev, 
			  struct switchdev_trans *trans)

{

	struct ethsw_port_priv *port_priv = netdev_priv(netdev);

	int vid, err;

	int vid, err = 0;



	if (netif_is_bridge_master(vlan->obj.orig_dev))

		return -EOPNOTSUPP;
@@ -872,7 +872,7 @@ static int port_vlans_del(struct net_device *netdev, 
			  const struct switchdev_obj_port_vlan *vlan)

{

	struct ethsw_port_priv *port_priv = netdev_priv(netdev);

	int vid, err;

	int vid, err = 0;



	if (netif_is_bridge_master(vlan->obj.orig_dev))

		return -EOPNOTSUPP;

CRA Git | Maintained and supported by SUSTech CRA and CCSE