Commit 7c3d0228 authored Feb 06, 2020 by Johan Hovold

USB: serial: ch341: fix receiver regression



While assumed not to make a difference, not using the factor-2 prescaler
makes the receiver more susceptible to errors.

Specifically, there have been reports of problems with devices that
cannot generate a 115200 rate with a smaller error than 2.1% (e.g.
117647 bps). But this can also be reproduced with a low-speed RS232
tranceiver at 115200 when the input rate matches the nominal rate.

So whenever possible, enable the factor-2 prescaler and halve the
divisor in order to use settings closer to that of the previous
algorithm.

Fixes: 35714565 ("USB: serial: ch341: reimplement line-speed handling")
Cc: stable <stable@vger.kernel.org>	# 5.5
Reported-by: Jakub Nantl <jn@forever.cz>
Tested-by: Jakub Nantl <jn@forever.cz>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>

parent c664a4fa

drivers/usb/serial/ch341.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -205,6 +205,16 @@ static int ch341_get_divisor(speed_t speed)
		16 * speed - 16 * CH341_CLKRATE / (clk_div * (div + 1)))
		div++;

		/*
		* Prefer lower base clock (fact = 0) if even divisor.
		*
		* Note that this makes the receiver more tolerant to errors.
		*/
		if (fact == 1 && div % 2 == 0) {
		div /= 2;
		fact = 0;
		}

		return (0x100 - div) << 8 \| fact << 2 \| ps;
		}

Admin message