Commit c664a4fa authored Jan 29, 2020 by Dan Carpenter Committed by Johan Hovold Feb 10, 2020

USB: serial: ir-usb: Silence harmless uninitialized variable warning



The "actual_length" variable might be uninitialized on some failure
paths.  It's harmless but static analysis tools like Smatch complain
and at runtime the UBSan tool will likely complain as well.

Fixes: e7542bc3 ("USB: serial: ir-usb: make set_termios synchronous")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johan Hovold <johan@kernel.org>

parent bb6d3fb3

drivers/usb/serial/ir-usb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -448,7 +448,7 @@ static void ir_set_termios(struct tty_struct *tty,
		usb_sndbulkpipe(udev, port->bulk_out_endpointAddress),
		transfer_buffer, 1, &actual_length, 5000);
		if (ret \|\| actual_length != 1) {
		if (actual_length != 1)
		if (!ret)
		ret = -EIO;
		dev_err(&port->dev, "failed to change line speed: %d\n", ret);
		}

Admin message