net: hns3: add max vector number check for pf (75edb610) · Commits · 戴 / test

Each pf supports max 64 vectors and 128 tqps. For 2p/4p core scenario, there may be more than 64 cpus online. So the result of min_t(u16, num_Online_cpus(), tqp_num) may be more than 64. This patch adds check for the vector number. Fixes: ("net: hns3: fix for coalesce configuration lost during reset") Signed-off-by:

Jian Shen <shenjian15@huawei.com> Signed-off-by:

Peng Li <lipeng321@huawei.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -3118,6 +3118,8 @@ map_ring_fail:

		static int hns3_nic_alloc_vector_data(struct hns3_nic_priv *priv)
		{
		#define HNS3_VECTOR_PF_MAX_NUM 64

		struct hnae3_handle *h = priv->ae_handle;
		struct hns3_enet_tqp_vector *tqp_vector;
		struct hnae3_vector_info *vector;
		@@ -3130,6 +3132,8 @@ static int hns3_nic_alloc_vector_data(struct hns3_nic_priv *priv)
		/* RSS size, cpu online and vector_num should be the same */
		/* Should consider 2p/4p later */
		vector_num = min_t(u16, num_online_cpus(), tqp_num);
		vector_num = min_t(u16, vector_num, HNS3_VECTOR_PF_MAX_NUM);

		vector = devm_kcalloc(&pdev->dev, vector_num, sizeof(*vector),
		GFP_KERNEL);
		if (!vector)

Admin message