net: hns3: fix a bug caused by udelay (1b7d7b05) · Commits · 戴 / test

udelay() in driver may always occupancy processor. If there is only one cpu in system, the VF driver may initialize fail when insmod PF and VF driver in the same system. This patch use msleep() to free cpu when VF wait PF message. Signed-off-by:

Peng Li <lipeng321@huawei.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -26,7 +26,7 @@ static int hclgevf_get_mbx_resp(struct hclgevf_dev *hdev, u16 code0, u16 code1,
		u8 *resp_data, u16 resp_len)
		{
		#define HCLGEVF_MAX_TRY_TIMES 500
		#define HCLGEVF_SLEEP_USCOEND 1000
		#define HCLGEVF_SLEEP_USECOND 1000
		struct hclgevf_mbx_resp_status *mbx_resp;
		u16 r_code0, r_code1;
		int i = 0;
		@@ -43,7 +43,7 @@ static int hclgevf_get_mbx_resp(struct hclgevf_dev *hdev, u16 code0, u16 code1,
		if (test_bit(HCLGEVF_STATE_CMD_DISABLE, &hdev->state))
		return -EIO;

		udelay(HCLGEVF_SLEEP_USCOEND);
		usleep_range(HCLGEVF_SLEEP_USECOND, HCLGEVF_SLEEP_USECOND * 2);
		i++;
		}

Admin message