Commit 7429c6c0 authored Jul 16, 2019 by Benjamin Poirier Committed by David S. Miller Jul 16, 2019

be2net: Signal that the device cannot transmit during reconfiguration



While changing the number of interrupt channels, be2net stops adapter
operation (including netif_tx_disable()) but it doesn't signal that it
cannot transmit. This may lead dev_watchdog() to falsely trigger during
that time.

Add the missing call to netif_carrier_off(), following the pattern used in
many other drivers. netif_carrier_on() is already taken care of in
be_open().

Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cf36dd2f

drivers/net/ethernet/emulex/benet/be_main.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -4697,8 +4697,12 @@ int be_update_queues(struct be_adapter *adapter)
		struct net_device *netdev = adapter->netdev;
		int status;

		if (netif_running(netdev))
		if (netif_running(netdev)) {
		/* device cannot transmit now, avoid dev_watchdog timeouts */
		netif_carrier_off(netdev);

		be_close(netdev);
		}

		be_cancel_worker(adapter);

Admin message