Commit cf36dd2f authored Jul 16, 2019 by Nishka Dasgupta Committed by David S. Miller Jul 16, 2019

net: ethernet: mediatek: mtk_eth_soc: Add of_node_put() before goto



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a goto from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 64fc973d

drivers/net/ethernet/mediatek/mtk_eth_soc.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2548,9 +2548,11 @@ static int mtk_probe(struct platform_device *pdev)
		continue;

		err = mtk_add_mac(eth, mac_np);
		if (err)
		if (err) {
		of_node_put(mac_np);
		goto err_deinit_hw;
		}
		}

		if (MTK_HAS_CAPS(eth->soc->caps, MTK_SHARED_INT)) {
		err = devm_request_irq(eth->dev, eth->irq[0],

Admin message