Commit 733e009c authored Mar 01, 2017 by Dmitry Torokhov Committed by Mauro Carvalho Chehab Mar 22, 2017

[media] Staging: media: radio-bcm2048: remove incorrect __exit markups



Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 78cea55c

drivers/staging/media/bcm2048/radio-bcm2048.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2642,7 +2642,7 @@ exit:
		return err;
		}

		static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
		static int bcm2048_i2c_driver_remove(struct i2c_client *client)
		{
		struct bcm2048_device *bdev = i2c_get_clientdata(client);

		@@ -2681,7 +2681,7 @@ static struct i2c_driver bcm2048_i2c_driver = {
		.name = BCM2048_DRIVER_NAME,
		},
		.probe = bcm2048_i2c_driver_probe,
		.remove = __exit_p(bcm2048_i2c_driver_remove),
		.remove = bcm2048_i2c_driver_remove,
		.id_table = bcm2048_id,
		};

Admin message