Commit 78cea55c authored Mar 01, 2017 by Dmitry Torokhov Committed by Mauro Carvalho Chehab Mar 22, 2017

[media] ad5820: remove incorrect __exit markups



Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 79e92dc0

drivers/media/i2c/ad5820.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -336,7 +336,7 @@ cleanup:
		return ret;
		}

		static int __exit ad5820_remove(struct i2c_client *client)
		static int ad5820_remove(struct i2c_client *client)
		{
		struct v4l2_subdev *subdev = i2c_get_clientdata(client);
		struct ad5820_device *coil = to_ad5820_device(subdev);
		@@ -362,7 +362,7 @@ static struct i2c_driver ad5820_i2c_driver = {
		.pm = &ad5820_pm,
		},
		.probe = ad5820_probe,
		.remove = __exit_p(ad5820_remove),
		.remove = ad5820_remove,
		.id_table = ad5820_id_table,
		};

Admin message