Commit 712e960f authored by Mika Westerberg's avatar Mika Westerberg Committed by Lee Jones
Browse files

ACPI / PM: Attach ACPI power domain only once 



Some devices, like MFD subdevices, share a single ACPI companion device so
that they are able to access their resources and children. However,
currently all these subdevices are attached to the ACPI power domain and
this might cause that the power methods for the companion device get called
more than once.

In order to solve this we attach the ACPI power domain only to the first
physical device that is bound to the ACPI companion device. In case of MFD
devices, this is the parent MFD device itself.

Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 13b2c4a0

drivers/acpi/device_pm.c

+8 −0
Original line number Original line Diff line number Diff line
@@ -1123,6 +1123,14 @@ int acpi_dev_pm_attach(struct device *dev, bool power_on) 
	if (dev->pm_domain)

	if (dev->pm_domain)

		return -EEXIST;

		return -EEXIST;





	/*

	 * Only attach the power domain to the first device if the

	 * companion is shared by multiple. This is to prevent doing power

	 * management twice.

	 */

	if (!acpi_device_is_first_physical_node(adev, dev))

		return -EBUSY;



	acpi_add_pm_notifier(adev, dev, acpi_pm_notify_work_func);

	acpi_add_pm_notifier(adev, dev, acpi_pm_notify_work_func);

	dev->pm_domain = &acpi_general_pm_domain;

	dev->pm_domain = &acpi_general_pm_domain;

	if (power_on) {

	if (power_on) {

drivers/acpi/internal.h

+2 −0
Original line number Original line Diff line number Diff line
@@ -97,6 +97,8 @@ void acpi_device_add_finalize(struct acpi_device *device); 
void acpi_free_pnp_ids(struct acpi_device_pnp *pnp);

void acpi_free_pnp_ids(struct acpi_device_pnp *pnp);

bool acpi_device_is_present(struct acpi_device *adev);

bool acpi_device_is_present(struct acpi_device *adev);

bool acpi_device_is_battery(struct acpi_device *adev);

bool acpi_device_is_battery(struct acpi_device *adev);

bool acpi_device_is_first_physical_node(struct acpi_device *adev,

					const struct device *dev);





/* --------------------------------------------------------------------------

/* --------------------------------------------------------------------------

                                  Power Resource

                                  Power Resource

drivers/acpi/scan.c

+30 −16
Original line number Original line Diff line number Diff line
@@ -226,6 +226,35 @@ static int create_of_modalias(struct acpi_device *acpi_dev, char *modalias, 
	return len;

	return len;

}

}





/**

 * acpi_device_is_first_physical_node - Is given dev first physical node

 * @adev: ACPI companion device

 * @dev: Physical device to check

 *

 * Function checks if given @dev is the first physical devices attached to

 * the ACPI companion device. This distinction is needed in some cases

 * where the same companion device is shared between many physical devices.

 *

 * Note that the caller have to provide valid @adev pointer.

 */

bool acpi_device_is_first_physical_node(struct acpi_device *adev,

					const struct device *dev)

{

	bool ret = false;



	mutex_lock(&adev->physical_node_lock);

	if (!list_empty(&adev->physical_node_list)) {

		const struct acpi_device_physical_node *node;



		node = list_first_entry(&adev->physical_node_list,

					struct acpi_device_physical_node, node);

		ret = node->dev == dev;

	}

	mutex_unlock(&adev->physical_node_lock);



	return ret;

}



/*

/*

 * acpi_companion_match() - Can we match via ACPI companion device

 * acpi_companion_match() - Can we match via ACPI companion device

 * @dev: Device in question

 * @dev: Device in question
@@ -250,7 +279,6 @@ static int create_of_modalias(struct acpi_device *acpi_dev, char *modalias, 
static struct acpi_device *acpi_companion_match(const struct device *dev)

static struct acpi_device *acpi_companion_match(const struct device *dev)

{

{

	struct acpi_device *adev;

	struct acpi_device *adev;

	struct mutex *physical_node_lock;





	adev = ACPI_COMPANION(dev);

	adev = ACPI_COMPANION(dev);

	if (!adev)

	if (!adev)
@@ -259,21 +287,7 @@ static struct acpi_device *acpi_companion_match(const struct device *dev) 
	if (list_empty(&adev->pnp.ids))

	if (list_empty(&adev->pnp.ids))

		return NULL;

		return NULL;





	physical_node_lock = &adev->physical_node_lock;

	return acpi_device_is_first_physical_node(adev, dev) ? adev : NULL;

	mutex_lock(physical_node_lock);

	if (list_empty(&adev->physical_node_list)) {

		adev = NULL;

	} else {

		const struct acpi_device_physical_node *node;



		node = list_first_entry(&adev->physical_node_list,

					struct acpi_device_physical_node, node);

		if (node->dev != dev)

			adev = NULL;

	}

	mutex_unlock(physical_node_lock);



	return adev;

}

}





static int __acpi_device_uevent_modalias(struct acpi_device *adev,

static int __acpi_device_uevent_modalias(struct acpi_device *adev,

CRA Git | Maintained and supported by SUSTech CRA and CCSE