Commit 13b2c4a0 authored by Mika Westerberg's avatar Mika Westerberg Committed by Lee Jones
Browse files

PM / QoS: Make it possible to expose device latency tolerance to userspace 



Typically when a device is created the bus core it belongs to (for example
PCI) does not know if the device supports things like latency tolerance.
This is left to the driver that binds to the device in question. However,
at that time the device has already been created and there is no way to set
its dev->power.set_latency_tolerance anymore.

So follow what has been done for other PM QoS attributes as well and allow
drivers to expose and hide latency tolerance from userspace, if the device
supports it.

Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent bc0195aa

drivers/base/power/power.h

+2 −0
Original line number Diff line number Diff line
@@ -73,6 +73,8 @@ extern int pm_qos_sysfs_add_resume_latency(struct device *dev); 
extern void pm_qos_sysfs_remove_resume_latency(struct device *dev);

extern int pm_qos_sysfs_add_flags(struct device *dev);

extern void pm_qos_sysfs_remove_flags(struct device *dev);

extern int pm_qos_sysfs_add_latency_tolerance(struct device *dev);

extern void pm_qos_sysfs_remove_latency_tolerance(struct device *dev);



#else /* CONFIG_PM */

drivers/base/power/qos.c

+37 −0
Original line number Diff line number Diff line
@@ -883,3 +883,40 @@ int dev_pm_qos_update_user_latency_tolerance(struct device *dev, s32 val) 
	mutex_unlock(&dev_pm_qos_mtx);

	return ret;

}



/**

 * dev_pm_qos_expose_latency_tolerance - Expose latency tolerance to userspace

 * @dev: Device whose latency tolerance to expose

 */

int dev_pm_qos_expose_latency_tolerance(struct device *dev)

{

	int ret;



	if (!dev->power.set_latency_tolerance)

		return -EINVAL;



	mutex_lock(&dev_pm_qos_sysfs_mtx);

	ret = pm_qos_sysfs_add_latency_tolerance(dev);

	mutex_unlock(&dev_pm_qos_sysfs_mtx);



	return ret;

}

EXPORT_SYMBOL_GPL(dev_pm_qos_expose_latency_tolerance);



/**

 * dev_pm_qos_hide_latency_tolerance - Hide latency tolerance from userspace

 * @dev: Device whose latency tolerance to hide

 */

void dev_pm_qos_hide_latency_tolerance(struct device *dev)

{

	mutex_lock(&dev_pm_qos_sysfs_mtx);

	pm_qos_sysfs_remove_latency_tolerance(dev);

	mutex_unlock(&dev_pm_qos_sysfs_mtx);



	/* Remove the request from user space now */

	pm_runtime_get_sync(dev);

	dev_pm_qos_update_user_latency_tolerance(dev,

		PM_QOS_LATENCY_TOLERANCE_NO_CONSTRAINT);

	pm_runtime_put(dev);

}

EXPORT_SYMBOL_GPL(dev_pm_qos_hide_latency_tolerance);

drivers/base/power/sysfs.c

+11 −0
Original line number Diff line number Diff line
@@ -738,6 +738,17 @@ void pm_qos_sysfs_remove_flags(struct device *dev) 
	sysfs_unmerge_group(&dev->kobj, &pm_qos_flags_attr_group);

}



int pm_qos_sysfs_add_latency_tolerance(struct device *dev)

{

	return sysfs_merge_group(&dev->kobj,

				 &pm_qos_latency_tolerance_attr_group);

}



void pm_qos_sysfs_remove_latency_tolerance(struct device *dev)

{

	sysfs_unmerge_group(&dev->kobj, &pm_qos_latency_tolerance_attr_group);

}



void rpm_sysfs_remove(struct device *dev)

{

	sysfs_unmerge_group(&dev->kobj, &pm_runtime_attr_group);

include/linux/pm_qos.h

+5 −0
Original line number Diff line number Diff line
@@ -161,6 +161,8 @@ void dev_pm_qos_hide_flags(struct device *dev); 
int dev_pm_qos_update_flags(struct device *dev, s32 mask, bool set);

s32 dev_pm_qos_get_user_latency_tolerance(struct device *dev);

int dev_pm_qos_update_user_latency_tolerance(struct device *dev, s32 val);

int dev_pm_qos_expose_latency_tolerance(struct device *dev);

void dev_pm_qos_hide_latency_tolerance(struct device *dev);



static inline s32 dev_pm_qos_requested_resume_latency(struct device *dev)

{
@@ -229,6 +231,9 @@ static inline s32 dev_pm_qos_get_user_latency_tolerance(struct device *dev) 
			{ return PM_QOS_LATENCY_TOLERANCE_NO_CONSTRAINT; }

static inline int dev_pm_qos_update_user_latency_tolerance(struct device *dev, s32 val)

			{ return 0; }

static inline int dev_pm_qos_expose_latency_tolerance(struct device *dev)

			{ return 0; }

static inline void dev_pm_qos_hide_latency_tolerance(struct device *dev) {}



static inline s32 dev_pm_qos_requested_resume_latency(struct device *dev) { return 0; }

static inline s32 dev_pm_qos_requested_flags(struct device *dev) { return 0; }

CRA Git | Maintained and supported by SUSTech CRA and CCSE