Commit 703fc3df authored by Jerry Hoemann's avatar Jerry Hoemann Committed by Wim Van Sebroeck
Browse files

watchdog: hpwdt: remove allow_kdump module parameter. 



The intent of this parameter is unclear and it sets up a
race between the reset of the system by ASR and crashdump.

The length of time between receipt of the pretimeout NMI
and the ASR reset of the system is fixed by hardware.

Turning the parameter off doesn't necessairly prevent a crash dump.
Also, having the ASR reset occur while the system is crash dumping
doesn't imply that the dump was hung given the short duration
between the NMI and the reset.

This parameter is not a substitute for having a architected watchdog
crashdump hang detection paridigm.

Signed-off-by: default avatarJerry Hoemann <jerry.hoemann@hpe.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent a6c24733

drivers/watchdog/hpwdt.c

+3 −13
Original line number Diff line number Diff line
@@ -36,9 +36,6 @@ static bool ilo5; 
static unsigned int soft_margin = DEFAULT_MARGIN;	/* in seconds */

static unsigned int reload;			/* the computed soft_margin */

static bool nowayout = WATCHDOG_NOWAYOUT;

#ifdef CONFIG_HPWDT_NMI_DECODING

static unsigned int allow_kdump = 1;

#endif



static void __iomem *pci_mem_addr;		/* the PCI-memory address */

static unsigned long __iomem *hpwdt_nmistat;
@@ -124,7 +121,6 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) 
	if (ilo5 && ulReason == NMI_UNKNOWN && mynmi)

		return NMI_DONE;



	if (allow_kdump)

	hpwdt_stop();



	hex_byte_pack(panic_msg, mynmi);
@@ -186,9 +182,8 @@ static int hpwdt_init_nmi_decoding(struct pci_dev *dev) 
		goto error2;



	dev_info(&dev->dev,

			"HPE Watchdog Timer Driver: NMI decoding initialized"

			", allow kernel dump: %s (default = 1/ON)\n",

			(allow_kdump == 0) ? "OFF" : "ON");

		"HPE Watchdog Timer Driver: NMI decoding initialized\n");



	return 0;



error2:
@@ -322,9 +317,4 @@ module_param(nowayout, bool, 0); 
MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="

		__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");



#ifdef CONFIG_HPWDT_NMI_DECODING

module_param(allow_kdump, int, 0);

MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs");

#endif /* CONFIG_HPWDT_NMI_DECODING */



module_pci_driver(hpwdt_driver);

CRA Git | Maintained and supported by SUSTech CRA and CCSE