watchdog: hpwdt: condition early return of NMI handler on iLO5 (a6c24733) · Commits · 戴 / test

Modify prior change to not claim an NMI unless originated from iLO to apply only to iLO5 and later going forward. This restores hpwdt traditional behavior of calling panic if the NMI is NMI_IO_CHECK, NMI_SERR, or NMI_UNKNOWN for legacy hardware. Signed-off-by:

Jerry Hoemann <jerry.hoemann@hpe.com> Signed-off-by:

Guenter Roeck <linux@roeck-us.net> Signed-off-by:

Wim Van Sebroeck <wim@iguana.be>

drivers/watchdog/hpwdt.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -32,6 +32,7 @@
		#define HPWDT_MAX_TIMER TICKS_TO_SECS(65535)
		#define DEFAULT_MARGIN 30

		static bool ilo5;
		static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */
		static unsigned int reload; /* the computed soft_margin */
		static bool nowayout = WATCHDOG_NOWAYOUT;
		@@ -120,7 +121,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
		"3. OA Forward Progress Log\n"
		"4. iLO Event Log";

		if ((ulReason == NMI_UNKNOWN) && mynmi)
		if (ilo5 && ulReason == NMI_UNKNOWN && mynmi)
		return NMI_DONE;

		if (allow_kdump)
		@@ -277,6 +278,9 @@ static int hpwdt_init_one(struct pci_dev *dev,
		", timer margin: %d seconds (nowayout=%d).\n",
		HPWDT_VERSION, hpwdt_dev.timeout, nowayout);

		if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR)
		ilo5 = true;

		return 0;

		error_wd_register:

Admin message