Commit 6f1891d0 authored Jun 19, 2013 by Benjamin Tissoires Committed by Jiri Kosina Jun 19, 2013

HID: fix false positive out of range values



Commit 6da70669 introduced in 3.3
"HID: ignore absolute values which don't fit between logical min and max"
prevents some Posiflex touch screen to work because they do not provide
logical min and max for their buttons.
Thus, logical min and max are at 0, discarding the buttons events, and
preventing the device to report appropriate X Y.

Adding a check on "min < max" solves the problem.

Reported-by: Jan Kandziora <jjj@gmx.de>
Tested-by: Jan Kandziora <jjj@gmx.de>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent a0be10c2

drivers/hid/hid-input.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1045,6 +1045,7 @@ void hidinput_hid_event(struct hid_device hid, struct hid_field field, struct
		* section 5.10 and 6.2.25
		*/
		if ((field->flags & HID_MAIN_ITEM_VARIABLE) &&
		(field->logical_minimum < field->logical_maximum) &&
		(value < field->logical_minimum \|\|
		value > field->logical_maximum)) {
		dbg_hid("Ignoring out-of-range value %x\n", value);

Admin message