Commit 6da70669 authored by Jiri Kosina's avatar Jiri Kosina
Browse files

HID: ignore absolute values which don't fit between logical min and max 



Linux should ignore values outside logical min/max range, as they are not
meaningful. This is what at least some of other OSes do, and it also makes
sense (currently the value gets misinterpreted larger up the stack).

Reported-by: default avatarDenilson Figueiredo de Sá <denilsonsa@gmail.com>
Tested-by: default avatarDenilson Figueiredo de Sá <denilsonsa@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent e46e927b

drivers/hid/hid-input.c

+7 −0
Original line number Diff line number Diff line
@@ -822,6 +822,13 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct 
		return;

	}



	/* Ignore absolute values that are out of bounds */

	if ((usage->type == EV_ABS && (value < field->logical_minimum ||

					value > field->logical_maximum))) {

		dbg_hid("Ignoring out-of-range value %x\n", value);

		return;

	}



	/* report the usage code as scancode if the key status has changed */

	if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)

		input_event(input, EV_MSC, MSC_SCAN, usage->hid);

CRA Git | Maintained and supported by SUSTech CRA and CCSE