Commit 6d2be915 authored Apr 03, 2014 by Raghavendra K T Committed by Linus Torvalds Apr 03, 2014

mm/readahead.c: fix readahead failure for memoryless NUMA nodes and limit readahead pages



Currently max_sane_readahead() returns zero on the cpu whose NUMA node
has no local memory which leads to readahead failure.  Fix this
readahead failure by returning minimum of (requested pages, 512).  Users
running applications on a memory-less cpu which needs readahead such as
streaming application see considerable boost in the performance.

Result:

fadvise experiment with FADV_WILLNEED on a PPC machine having memoryless
CPU with 1GB testfile (12 iterations) yielded around 46.66% improvement.

fadvise experiment with FADV_WILLNEED on a x240 machine with 1GB
testfile 32GB* 4G RAM numa machine (12 iterations) showed no impact on
the normal NUMA cases w/ patch.

  Kernel       Avg  Stddev
  base      7.4975   3.92%
  patched   7.4174   3.26%

[Andrew: making return value PAGE_SIZE independent]
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Acked-by: Jan Kara <jack@suse.cz>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 421af243

mm/readahead.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -233,14 +233,14 @@ int force_page_cache_readahead(struct address_space mapping, struct file filp,
		return 0;
		}

		#define MAX_READAHEAD ((512*4096)/PAGE_CACHE_SIZE)
		/*
		* Given a desired number of PAGE_CACHE_SIZE readahead pages, return a
		* sensible upper limit.
		*/
		unsigned long max_sane_readahead(unsigned long nr)
		{
		return min(nr, (node_page_state(numa_node_id(), NR_INACTIVE_FILE)
		+ node_page_state(numa_node_id(), NR_FREE_PAGES)) / 2);
		return min(nr, MAX_READAHEAD);
		}

		/*

Admin message