Commit 421af243 authored Apr 03, 2014 by Vladimir Davydov Committed by Linus Torvalds Apr 03, 2014

slub: do not drop slab_mutex for sysfs_slab_add



We release the slab_mutex while calling sysfs_slab_add from
__kmem_cache_create since commit 66c4c35c ("slub: Do not hold
slub_lock when calling sysfs_slab_add()"), because kobject_uevent called
by sysfs_slab_add might block waiting for the usermode helper to exec,
which would result in a deadlock if we took the slab_mutex while
executing it.

However, apart from complicating synchronization rules, releasing the
slab_mutex on kmem cache creation can result in a kmemcg-related race.
The point is that we check if the memcg cache exists before going to
__kmem_cache_create, but register the new cache in memcg subsys after
it.  Since we can drop the mutex there, several threads can see that the
memcg cache does not exist and proceed to creating it, which is wrong.

Fortunately, recently kobject_uevent was patched to call the usermode
helper with the UMH_NO_WAIT flag, making the deadlock impossible.
Therefore there is no point in releasing the slab_mutex while calling
sysfs_slab_add, so let's simplify kmem_cache_create synchronization and
fix the kmemcg-race mentioned above by holding the slab_mutex during the
whole cache creation path.

Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Acked-by: Christoph Lameter <cl@linux.com>
Cc: Greg KH <greg@kroah.com>
Cc: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent bcccff93

mm/slub.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -3237,8 +3237,9 @@ int __kmem_cache_shutdown(struct kmem_cache *s)

		if (!rc) {
		/*
		* We do the same lock strategy around sysfs_slab_add, see
		* __kmem_cache_create. Because this is pretty much the last
		* Since slab_attr_store may take the slab_mutex, we should
		* release the lock while removing the sysfs entry in order to
		* avoid a deadlock. Because this is pretty much the last
		* operation we do and the lock will be released shortly after
		* that in slab_common.c, we could just move sysfs_slab_remove
		* to a later point in common code. We should do that when we
		@@ -3778,10 +3779,7 @@ int __kmem_cache_create(struct kmem_cache *s, unsigned long flags)
		return 0;

		memcg_propagate_slab_attrs(s);
		mutex_unlock(&slab_mutex);
		err = sysfs_slab_add(s);
		mutex_lock(&slab_mutex);

		if (err)
		kmem_cache_close(s);

Admin message