ALSA: echoaudio: Prevent races in calls to set_audio_format() (6c331254) · Commits · 戴 / test

The function uses chip->comm_page which needs locking against other use at the same time. Signed-off-by:

sound/pci/echoaudio/echoaudio.c

+14 −1

Original line number	Diff line number	Diff line
		@@ -711,9 +711,22 @@ static int pcm_prepare(struct snd_pcm_substream *substream)

		if (snd_BUG_ON(pipe_index >= px_num(chip)))
		return -EINVAL;
		if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index)))

		/*
		* We passed checks we can do independently; now take
		* exclusive control
		*/

		spin_lock_irq(&chip->lock);

		if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index))) {
		spin_unlock(&chip->lock);
		return -EINVAL;
		}

		set_audio_format(chip, pipe_index, &format);
		spin_unlock_irq(&chip->lock);

		return 0;
		}