Commit 6b8e327c authored by Nathan Chancellor's avatar Nathan Chancellor Committed by David S. Miller
Browse files

net: fddi: skfp: Remove unused function 

Clang warns when a variable is assigned to itself.

drivers/net/fddi/skfp/pcmplc.c:1257:6: warning: explicitly assigning
value of variable of type 'int' to itself [-Wself-assign]
        phy = phy ; on_off = on_off ;
        ~~~ ^ ~~~
drivers/net/fddi/skfp/pcmplc.c:1257:21: warning: explicitly assigning
value of variable of type 'int' to itself [-Wself-assign]
        phy = phy ; on_off = on_off ;
                    ~~~~~~ ^ ~~~~~~
2 warnings generated.

Turns out this entire function doesn't actually do anything since
SK_UNUSED is just casting the pointer to void. Remove it to silence
this Clang warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/128


Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 83b4768e

drivers/net/fddi/skfp/ecm.c

+0 −3
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ 
 *

 * 	The following external HW dependent functions are referenced :

 * 		sm_pm_bypass_req()

 * 		sm_pm_ls_latch()

 * 		sm_pm_get_ls()

 * 

 * 	The following HW dependent events are required :
@@ -356,8 +355,6 @@ static void ecm_fsm(struct s_smc *smc, int cmd) 
		 */

		start_ecm_timer(smc,smc->s.ecm_check_poll,0) ;

		smc->e.ecm_line_state = TRUE ;	/* flag to pcm: report Q/HLS */

		(void) sm_pm_ls_latch(smc,PA,1) ; /* enable line state latch */

		(void) sm_pm_ls_latch(smc,PB,1) ; /* enable line state latch */

		ACTIONS_DONE() ;

		break ;

	case EC6_CHECK :

drivers/net/fddi/skfp/h/cmtdef.h

+0 −1
Original line number Diff line number Diff line
@@ -513,7 +513,6 @@ void pcm_status_state(struct s_smc *smc, int np, int *type, int *state, 
void plc_config_mux(struct s_smc *smc, int mux);

void sm_lem_evaluate(struct s_smc *smc);

void mac_update_counter(struct s_smc *smc);

void sm_pm_ls_latch(struct s_smc *smc, int phy, int on_off);

void sm_ma_control(struct s_smc *smc, int mode);

void sm_mac_check_beacon_claim(struct s_smc *smc);

void config_mux(struct s_smc *smc, int mux);

drivers/net/fddi/skfp/pcmplc.c

+0 −11
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ 
 * 	The following external HW dependent functions are referenced :

 * 		sm_pm_control()

 *		sm_ph_linestate()

 *		sm_pm_ls_latch()

 *

 * 	The following HW dependent events are required :

 *		PC_QLS
@@ -1248,16 +1247,6 @@ static void sm_ph_lem_stop(struct s_smc *smc, int np) 
	CLEAR(PLC(np,PL_INTR_MASK),PL_LE_CTR) ;

}



/* ARGSUSED */

void sm_pm_ls_latch(struct s_smc *smc, int phy, int on_off)

/* int on_off;	en- or disable ident. ls */

{

	SK_UNUSED(smc) ;



	phy = phy ; on_off = on_off ;

}





/*

 * PCM pseudo code

 * receive actions are called AFTER the bit n is received,

CRA Git | Maintained and supported by SUSTech CRA and CCSE