bna: Remove unnecessary self assignment (83b4768e) · Commits · 戴 / test

Clang warns when a variable is assigned to itself. drivers/net/ethernet/brocade/bna/bna_enet.c:1800:9: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] for (i = i; i < (bna->ioceth.attr.num_ucmac * 2); i++) ~ ^ ~ drivers/net/ethernet/brocade/bna/bna_enet.c:1835:9: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] for (i = i; i < (bna->ioceth.attr.num_mcmac * 2); i++) ~ ^ ~ 2 warnings generated. Link: https://github.com/ClangBuiltLinux/linux/issues/110 Signed-off-by:

Nathan Chancellor <natechancellor@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/brocade/bna/bna_enet.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1797,7 +1797,7 @@ bna_ucam_mod_init(struct bna_ucam_mod ucam_mod, struct bna bna,

		/* A separate queue to allow synchronous setting of a list of MACs */
		INIT_LIST_HEAD(&ucam_mod->del_q);
		for (i = i; i < (bna->ioceth.attr.num_ucmac * 2); i++)
		for (; i < (bna->ioceth.attr.num_ucmac * 2); i++)
		list_add_tail(&ucam_mod->ucmac[i].qe, &ucam_mod->del_q);

		ucam_mod->bna = bna;
		@@ -1832,7 +1832,7 @@ bna_mcam_mod_init(struct bna_mcam_mod mcam_mod, struct bna bna,

		/* A separate queue to allow synchronous setting of a list of MACs */
		INIT_LIST_HEAD(&mcam_mod->del_q);
		for (i = i; i < (bna->ioceth.attr.num_mcmac * 2); i++)
		for (; i < (bna->ioceth.attr.num_mcmac * 2); i++)
		list_add_tail(&mcam_mod->mcmac[i].qe, &mcam_mod->del_q);

		mcam_mod->bna = bna;

Admin message