ASoC: cros_ec_codec: Use managed buffer allocation (66b3621b) · Commits · 戴 / test

Clean up the driver with the new managed buffer allocation API. The superfluous snd_pcm_lib_malloc_pages() and snd_pcm_lib_free_pages() calls are dropped. Cc: Cheng-Yi Chiang <cychiang@chromium.org> Cc: Benson Leung <bleung@chromium.org> Signed-off-by:

Takashi Iwai <tiwai@suse.de> Link: https://lore.kernel.org/r/20191210142614.19405-18-tiwai@suse.de Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/codecs/cros_ec_codec.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -918,7 +918,7 @@ static int wov_pcm_hw_params(struct snd_soc_component *component,
		priv->wov_burst_read = true;
		mutex_unlock(&priv->wov_dma_lock);

		return snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(hw_params));
		return 0;
		}

		static int wov_pcm_hw_free(struct snd_soc_component *component,
		@@ -934,7 +934,7 @@ static int wov_pcm_hw_free(struct snd_soc_component *component,

		cancel_delayed_work_sync(&priv->wov_copy_work);

		return snd_pcm_lib_free_pages(substream);
		return 0;
		}

		static snd_pcm_uframes_t wov_pcm_pointer(struct snd_soc_component *component,
		@@ -950,7 +950,7 @@ static snd_pcm_uframes_t wov_pcm_pointer(struct snd_soc_component *component,
		static int wov_pcm_new(struct snd_soc_component *component,
		struct snd_soc_pcm_runtime *rtd)
		{
		snd_pcm_lib_preallocate_pages_for_all(rtd->pcm, SNDRV_DMA_TYPE_VMALLOC,
		snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_VMALLOC,
		NULL, 0, 0);
		return 0;
		}

Admin message