Unverified Commit bfddcaff authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: xtensa: Use managed buffer allocation 



Clean up the driver with the new managed buffer allocation API.
The superfluous snd_pcm_lib_malloc_pages() and
snd_pcm_lib_free_pages() calls are dropped.

Cc: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20191210142614.19405-17-tiwai@suse.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 52f0ac15

sound/soc/xtensa/xtfpga-i2s.c

+3 −6
Original line number Diff line number Diff line
@@ -390,7 +390,6 @@ static int xtfpga_pcm_hw_params(struct snd_soc_component *component, 
				struct snd_pcm_substream *substream,

				struct snd_pcm_hw_params *hw_params)

{

	int ret;

	struct snd_pcm_runtime *runtime = substream->runtime;

	struct xtfpga_i2s *i2s = runtime->private_data;

	unsigned channels = params_channels(hw_params);
@@ -422,9 +421,7 @@ static int xtfpga_pcm_hw_params(struct snd_soc_component *component, 
		return -EINVAL;

	}



	ret = snd_pcm_lib_malloc_pages(substream,

				       params_buffer_bytes(hw_params));

	return ret;

	return 0;

}



static int xtfpga_pcm_trigger(struct snd_soc_component *component,
@@ -472,7 +469,7 @@ static int xtfpga_pcm_new(struct snd_soc_component *component, 
	struct snd_card *card = rtd->card->snd_card;

	size_t size = xtfpga_pcm_hardware.buffer_bytes_max;



	snd_pcm_lib_preallocate_pages_for_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,

	snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,

				       card->dev, size, size);

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE