Commit 66883da1 authored May 24, 2019 by Gabriel Krisman Bertazi Committed by Theodore Ts'o May 24, 2019

ext4: fix dcache lookup of !casefolded directories



Found by visual inspection, this wasn't caught by my xfstest, since it's
effect is ignoring positive dentries in the cache the fallback just goes
to the disk.  it was introduced in the last iteration of the
case-insensitive patch.

d_compare should return 0 when the entries match, so make sure we are
correctly comparing the entire string if the encoding feature is set and
we are on a case-INsensitive directory.

Fixes: b886ee3e ("ext4: Support case-insensitive file name lookups")
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent ee0ed02c

fs/ext4/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -671,7 +671,7 @@ static int ext4_d_compare(const struct dentry *dentry, unsigned int len,
		if (!IS_CASEFOLDED(dentry->d_parent->d_inode)) {
		if (len != name->len)
		return -1;
		return !memcmp(str, name, len);
		return memcmp(str, name->name, len);
		}

		return ext4_ci_compare(dentry->d_parent->d_inode, name, &qstr);

Admin message