Commit ee0ed02c authored May 23, 2019 by Jan Kara Committed by Theodore Ts'o May 23, 2019

ext4: do not delete unlinked inode from orphan list on failed truncate



It is possible that unlinked inode enters ext4_setattr() (e.g. if
somebody calls ftruncate(2) on unlinked but still open file). In such
case we should not delete the inode from the orphan list if truncate
fails. Note that this is mostly a theoretical concern as filesystem is
corrupted if we reach this path anyway but let's be consistent in our
orphan handling.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org

parent 82a25b02

fs/ext4/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5625,7 +5625,7 @@ int ext4_setattr(struct dentry dentry, struct iattr attr)
		up_write(&EXT4_I(inode)->i_data_sem);
		ext4_journal_stop(handle);
		if (error) {
		if (orphan)
		if (orphan && inode->i_nlink)
		ext4_orphan_del(NULL, inode);
		goto err_out;
		}

Admin message