Commit 6647e4e8 authored Nov 03, 2019 by Davidlohr Bueso Committed by Greg Kroah-Hartman Nov 03, 2019

staging: exfat: Ensure we unlock upon error in ffsReadFile



The call was not releasing the mutex upon error.

Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Acked-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191103180921.2844-1-dave@stgolabs.net


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 19c1e145

drivers/staging/exfat/exfat_super.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -743,8 +743,10 @@ static int ffsReadFile(struct inode inode, struct file_id_t fid, void *buffer,

		while (clu_offset > 0) {
		/* clu = FAT_read(sb, clu); */
		if (FAT_read(sb, clu, &clu) == -1)
		return FFS_MEDIAERR;
		if (FAT_read(sb, clu, &clu) == -1) {
		ret = FFS_MEDIAERR;
		goto out;
		}

		clu_offset--;
		}

Admin message