Commit 19c1e145 authored by Javier F. Arias's avatar Javier F. Arias Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: Remove unnecessary parentheses 



This patch removes unnecessary parentheses.
Issue found by checkpatch

Signed-off-by: default avatarJavier F. Arias <jarias.linux@gmail.com>
Link: https://lore.kernel.org/r/b2526b464b8afed3b2c3a3a72ae183fb63df3ae7.1572734925.git.jarias.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1878c5b9

drivers/staging/rtl8723bs/core/rtw_xmit.c

+31 −31
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) 
	pxframe = (struct xmit_frame *) pxmitpriv->pxmit_frame_buf;



	for (i = 0; i < NR_XMITFRAME; i++) {

		INIT_LIST_HEAD(&(pxframe->list));

		INIT_LIST_HEAD(&pxframe->list);



		pxframe->padapter = padapter;

		pxframe->frame_tag = NULL_FRAMETAG;
@@ -99,7 +99,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) 
		pxframe->buf_addr = NULL;

		pxframe->pxmitbuf = NULL;



		list_add_tail(&(pxframe->list), &(pxmitpriv->free_xmit_queue.queue));

		list_add_tail(&pxframe->list, &pxmitpriv->free_xmit_queue.queue);



		pxframe++;

	}
@@ -150,7 +150,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) 


		pxmitbuf->flags = XMIT_VO_QUEUE;



		list_add_tail(&pxmitbuf->list, &(pxmitpriv->free_xmitbuf_queue.queue));

		list_add_tail(&pxmitbuf->list, &pxmitpriv->free_xmitbuf_queue.queue);

		#ifdef DBG_XMIT_BUF

		pxmitbuf->no = i;

		#endif
@@ -176,7 +176,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) 
	pxframe = (struct xmit_frame *)pxmitpriv->xframe_ext;



	for (i = 0; i < NR_XMIT_EXTBUFF; i++) {

		INIT_LIST_HEAD(&(pxframe->list));

		INIT_LIST_HEAD(&pxframe->list);



		pxframe->padapter = padapter;

		pxframe->frame_tag = NULL_FRAMETAG;
@@ -188,7 +188,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) 


		pxframe->ext_tag = 1;



		list_add_tail(&(pxframe->list), &(pxmitpriv->free_xframe_ext_queue.queue));

		list_add_tail(&pxframe->list, &pxmitpriv->free_xframe_ext_queue.queue);



		pxframe++;

	}
@@ -227,7 +227,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) 
		pxmitbuf->len = 0;

		pxmitbuf->pdata = pxmitbuf->ptail = pxmitbuf->phead;



		list_add_tail(&pxmitbuf->list, &(pxmitpriv->free_xmit_extbuf_queue.queue));

		list_add_tail(&pxmitbuf->list, &pxmitpriv->free_xmit_extbuf_queue.queue);

		#ifdef DBG_XMIT_BUF_EXT

		pxmitbuf->no = i;

		#endif
@@ -372,8 +372,8 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame * 
	u32 sz;

	struct pkt_attrib	*pattrib = &pxmitframe->attrib;

	/* struct sta_info *psta = pattrib->psta; */

	struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);

	struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);

	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;

	struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;



	if (pattrib->nr_frags != 1)

		sz = padapter->xmitpriv.frag_len;
@@ -955,7 +955,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr 
					RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("curfragnum =%d length =%d pattrib->icv_len =%d", curfragnum, length, pattrib->icv_len));

				}

			}

			rtw_secgetmic(&micdata, &(mic[0]));

			rtw_secgetmic(&micdata, &mic[0]);

			RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("xmitframe_addmic: before add mic code!!!\n"));

			RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("xmitframe_addmic: pattrib->last_txcmdsz =%d!!!\n", pattrib->last_txcmdsz));

			RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("xmitframe_addmic: mic[0]= 0x%.2x , mic[1]= 0x%.2x , mic[2]= 0x%.2x , mic[3]= 0x%.2x\n\
@@ -963,7 +963,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr 
				mic[0], mic[1], mic[2], mic[3], mic[4], mic[5], mic[6], mic[7]));

			/* add mic code  and add the mic code length in last_txcmdsz */



			memcpy(payload, &(mic[0]), 8);

			memcpy(payload, &mic[0], 8);

			pattrib->last_txcmdsz += 8;



			RT_TRACE(_module_rtl871x_xmit_c_, _drv_info_, ("\n ========last pkt ========\n"));
@@ -1029,7 +1029,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr 
	SetFrameSubType(fctrl, pattrib->subtype);



	if (pattrib->subtype & WIFI_DATA_TYPE) {

		if ((check_fwstate(pmlmepriv,  WIFI_STATION_STATE) == true)) {

		if (check_fwstate(pmlmepriv,  WIFI_STATION_STATE) == true) {

			/* to_ds = 1, fr_ds = 0; */



			{
@@ -1044,7 +1044,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr 
			if (pqospriv->qos_option)

				qos_option = true;



		} else if ((check_fwstate(pmlmepriv,  WIFI_AP_STATE) == true)) {

		} else if (check_fwstate(pmlmepriv,  WIFI_AP_STATE) == true) {

			/* to_ds = 0, fr_ds = 1; */

			SetFrDs(fctrl);

			memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN);
@@ -1409,7 +1409,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, _pkt *pkt, struct xmit 
		pmlmeext->mgnt_80211w_IPN++;



		/* add MME IE with MIC all zero, MME string doesn't include element id and length */

		pframe = rtw_set_ie(pframe, _MME_IE_, 16, MME, &(pattrib->pktlen));

		pframe = rtw_set_ie(pframe, _MME_IE_, 16, MME, &pattrib->pktlen);

		pattrib->last_txcmdsz = pattrib->pktlen;

		/*  total frame length - header length */

		frame_body_len = pattrib->pktlen - sizeof(struct ieee80211_hdr_3addr);
@@ -1687,7 +1687,7 @@ struct xmit_buf *rtw_alloc_xmitbuf_ext(struct xmit_priv *pxmitpriv) 


		pxmitbuf = LIST_CONTAINOR(plist, struct xmit_buf, list);



		list_del_init(&(pxmitbuf->list));

		list_del_init(&pxmitbuf->list);

	}



	if (pxmitbuf) {
@@ -1727,7 +1727,7 @@ s32 rtw_free_xmitbuf_ext(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) 


	list_del_init(&pxmitbuf->list);



	list_add_tail(&(pxmitbuf->list), get_list_head(pfree_queue));

	list_add_tail(&pxmitbuf->list, get_list_head(pfree_queue));

	pxmitpriv->free_xmit_extbuf_cnt++;

	#ifdef DBG_XMIT_BUF_EXT

	DBG_871X("DBG_XMIT_BUF_EXT FREE no =%d, free_xmit_extbuf_cnt =%d\n", pxmitbuf->no, pxmitpriv->free_xmit_extbuf_cnt);
@@ -1759,7 +1759,7 @@ struct xmit_buf *rtw_alloc_xmitbuf(struct xmit_priv *pxmitpriv) 


		pxmitbuf = LIST_CONTAINOR(plist, struct xmit_buf, list);



		list_del_init(&(pxmitbuf->list));

		list_del_init(&pxmitbuf->list);

	}



	if (pxmitbuf) {
@@ -1814,7 +1814,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) 


		list_del_init(&pxmitbuf->list);



		list_add_tail(&(pxmitbuf->list), get_list_head(pfree_xmitbuf_queue));

		list_add_tail(&pxmitbuf->list, get_list_head(pfree_xmitbuf_queue));



		pxmitpriv->free_xmitbuf_cnt++;

		/* DBG_871X("FREE, free_xmitbuf_cnt =%d\n", pxmitpriv->free_xmitbuf_cnt); */
@@ -1878,7 +1878,7 @@ struct xmit_frame *rtw_alloc_xmitframe(struct xmit_priv *pxmitpriv)/* _queue *pf 


		pxframe = LIST_CONTAINOR(plist, struct xmit_frame, list);



		list_del_init(&(pxframe->list));

		list_del_init(&pxframe->list);

		pxmitpriv->free_xmitframe_cnt--;

		RT_TRACE(_module_rtl871x_xmit_c_, _drv_info_, ("rtw_alloc_xmitframe():free_xmitframe_cnt =%d\n", pxmitpriv->free_xmitframe_cnt));

	}
@@ -1905,7 +1905,7 @@ struct xmit_frame *rtw_alloc_xmitframe_ext(struct xmit_priv *pxmitpriv) 
		plist = get_next(phead);

		pxframe = LIST_CONTAINOR(plist, struct xmit_frame, list);



		list_del_init(&(pxframe->list));

		list_del_init(&pxframe->list);

		pxmitpriv->free_xframe_ext_cnt--;

		RT_TRACE(_module_rtl871x_xmit_c_, _drv_info_, ("rtw_alloc_xmitframe_ext():free_xmitframe_cnt =%d\n", pxmitpriv->free_xframe_ext_cnt));

	}
@@ -2005,7 +2005,7 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pfram 
	struct list_head	*plist, *phead;

	struct	xmit_frame	*pxmitframe;



	spin_lock_bh(&(pframequeue->lock));

	spin_lock_bh(&pframequeue->lock);



	phead = get_list_head(pframequeue);

	plist = get_next(phead);
@@ -2019,7 +2019,7 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pfram 
		rtw_free_xmitframe(pxmitpriv, pxmitframe);



	}

	spin_unlock_bh(&(pframequeue->lock));

	spin_unlock_bh(&pframequeue->lock);

}



s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe)
@@ -2042,21 +2042,21 @@ struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_info * 
	switch (up) {

	case 1:

	case 2:

		ptxservq = &(psta->sta_xmitpriv.bk_q);

		ptxservq = &psta->sta_xmitpriv.bk_q;

		*(ac) = 3;

		RT_TRACE(_module_rtl871x_xmit_c_, _drv_info_, ("rtw_get_sta_pending : BK\n"));

		break;



	case 4:

	case 5:

		ptxservq = &(psta->sta_xmitpriv.vi_q);

		ptxservq = &psta->sta_xmitpriv.vi_q;

		*(ac) = 1;

		RT_TRACE(_module_rtl871x_xmit_c_, _drv_info_, ("rtw_get_sta_pending : VI\n"));

		break;



	case 6:

	case 7:

		ptxservq = &(psta->sta_xmitpriv.vo_q);

		ptxservq = &psta->sta_xmitpriv.vo_q;

		*(ac) = 0;

		RT_TRACE(_module_rtl871x_xmit_c_, _drv_info_, ("rtw_get_sta_pending : VO\n"));

		break;
@@ -2064,7 +2064,7 @@ struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_info * 
	case 0:

	case 3:

	default:

		ptxservq = &(psta->sta_xmitpriv.be_q);

		ptxservq = &psta->sta_xmitpriv.be_q;

		*(ac) = 2;

		RT_TRACE(_module_rtl871x_xmit_c_, _drv_info_, ("rtw_get_sta_pending : BE\n"));

	break;
@@ -2600,24 +2600,24 @@ void stop_sta_xmit(struct adapter *padapter, struct sta_info *psta) 




	dequeue_xmitframes_to_sleeping_queue(padapter, psta, &pstaxmitpriv->vo_q.sta_pending);

	list_del_init(&(pstaxmitpriv->vo_q.tx_pending));

	list_del_init(&pstaxmitpriv->vo_q.tx_pending);





	dequeue_xmitframes_to_sleeping_queue(padapter, psta, &pstaxmitpriv->vi_q.sta_pending);

	list_del_init(&(pstaxmitpriv->vi_q.tx_pending));

	list_del_init(&pstaxmitpriv->vi_q.tx_pending);





	dequeue_xmitframes_to_sleeping_queue(padapter, psta, &pstaxmitpriv->be_q.sta_pending);

	list_del_init(&(pstaxmitpriv->be_q.tx_pending));

	list_del_init(&pstaxmitpriv->be_q.tx_pending);





	dequeue_xmitframes_to_sleeping_queue(padapter, psta, &pstaxmitpriv->bk_q.sta_pending);

	list_del_init(&(pstaxmitpriv->bk_q.tx_pending));

	list_del_init(&pstaxmitpriv->bk_q.tx_pending);



	/* for BC/MC Frames */

	pstaxmitpriv = &psta_bmc->sta_xmitpriv;

	dequeue_xmitframes_to_sleeping_queue(padapter, psta_bmc, &pstaxmitpriv->be_q.sta_pending);

	list_del_init(&(pstaxmitpriv->be_q.tx_pending));

	list_del_init(&pstaxmitpriv->be_q.tx_pending);



	spin_unlock_bh(&pxmitpriv->lock);

}
@@ -2863,7 +2863,7 @@ void enqueue_pending_xmitbuf( 
	list_add_tail(&pxmitbuf->list, get_list_head(pqueue));

	spin_unlock_bh(&pqueue->lock);



	complete(&(pri_adapter->xmitpriv.xmit_comp));

	complete(&pri_adapter->xmitpriv.xmit_comp);

}



void enqueue_pending_xmitbuf_to_head(

CRA Git | Maintained and supported by SUSTech CRA and CCSE