Commit 65f662cb authored Jun 04, 2019 by Chen-Yu Tsai Committed by Alexandre Belloni Jun 20, 2019

rtc: pcf8563: Fix interrupt trigger method



The PCF8563 datasheet says the interrupt line is active low and stays
active until the events are cleared, i.e. a level trigger interrupt.

Fix the flags used to request the interrupt.

Fixes: ede3e9d4 ("drivers/rtc/rtc-pcf8563.c: add alarm support")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

parent fedc459a

drivers/rtc/rtc-pcf8563.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -605,7 +605,7 @@ static int pcf8563_probe(struct i2c_client *client,
		if (client->irq > 0) {
		err = devm_request_threaded_irq(&client->dev, client->irq,
		NULL, pcf8563_irq,
		IRQF_SHARED\|IRQF_ONESHOT\|IRQF_TRIGGER_FALLING,
		IRQF_SHARED \| IRQF_ONESHOT \| IRQF_TRIGGER_LOW,
		pcf8563_driver.driver.name, client);
		if (err) {
		dev_err(&client->dev, "unable to request IRQ %d\n",

Admin message