Commit fedc459a authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: pcf2123: fix negative offset rounding 



Using result = (value + divisor/2) / divisor is rounding values up and only
works well for positive values. Instead use DIV_ROUND_CLOSEST which does
the correct thing.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent e32e60a2

drivers/rtc/rtc-pcf2123.c

+1 −1
Original line number Diff line number Diff line
@@ -161,7 +161,7 @@ static int pcf2123_set_offset(struct device *dev, long offset) 
	else if (offset < OFFSET_STEP * -128)

		reg = -128;

	else

		reg = (s8)((offset + (OFFSET_STEP >> 1)) / OFFSET_STEP);

		reg = DIV_ROUND_CLOSEST(offset, OFFSET_STEP);



	/* choose fine offset only for odd values in the normal range */

	if (reg & 1 && reg <= 63 && reg >= -64) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE