Commit 634b06de authored Jul 21, 2020 by Xiongfeng Wang Committed by Corey Minyard Jul 21, 2020

ipmi/watchdog: add missing newlines when printing parameters by sysfs



When I cat some ipmi_watchdog parameters by sysfs, it displays as
follows. It's better to add a newline for easy reading.

root@(none):/# cat /sys/module/ipmi_watchdog/parameters/action
resetroot@(none):/# cat /sys/module/ipmi_watchdog/parameters/preaction
pre_noneroot@(none):/# cat /sys/module/ipmi_watchdog/parameters/preop
preop_noneroot@(none):/#

Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Message-Id: <1595313309-43881-1-git-send-email-wangxiongfeng2@huawei.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>

parent a7f0f92a

drivers/char/ipmi/ipmi_watchdog.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -232,12 +232,17 @@ static int set_param_str(const char val, const struct kernel_param kp)
		static int get_param_str(char buffer, const struct kernel_param kp)
		{
		action_fn fn = (action_fn) kp->arg;
		int rv;
		int rv, len;

		rv = fn(NULL, buffer);
		if (rv)
		return rv;
		return strlen(buffer);

		len = strlen(buffer);
		buffer[len++] = '\n';
		buffer[len] = 0;

		return len;
		}

Admin message