Commit a7f0f92a authored Jul 20, 2020 by Jing Xiangfeng Committed by Corey Minyard Jul 20, 2020

ipmi: remve duplicate code in __ipmi_bmc_register()



__ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an
error path. So we can remove duplicate code in the if (rv).

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Message-Id: <20200720080838.148737-1-jingxiangfeng@huawei.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>

parent 29a54910

drivers/char/ipmi/ipmi_msghandler.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -3080,8 +3080,6 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf,
		rv = sysfs_create_link(&bmc->pdev.dev.kobj, &intf->si_dev->kobj,
		intf->my_dev_name);
		if (rv) {
		kfree(intf->my_dev_name);
		intf->my_dev_name = NULL;
		dev_err(intf->si_dev, "Unable to create symlink to bmc: %d\n",
		rv);
		goto out_free_my_dev_name;

Admin message