Commit 6299358d authored by James Dingwall's avatar James Dingwall Committed by Christoph Hellwig
Browse files

nvme: introduce NVME_QUIRK_IGNORE_DEV_SUBNQN 



If a device provides an NQN it is expected to be globally unique.
Unfortunately some firmware revisions for Intel 760p/Pro 7600p devices did
not satisfy this requirement.  In these circumstances if a system has >1
affected device then only one device is enabled.  If this quirk is enabled
then the device supplied subnqn is ignored and we fallback to generating
one as if the field was empty.  In this case we also suppress the version
check so we don't print a warning when the quirk is enabled.

Reviewed-by: default avatarKeith Busch <keith.busch@intel.com>
Signed-off-by: default avatarJames Dingwall <james@dingwall.me.uk>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 3da584f5

drivers/nvme/host/core.c

+9 −7
Original line number Diff line number Diff line
@@ -2173,6 +2173,7 @@ static void nvme_init_subnqn(struct nvme_subsystem *subsys, struct nvme_ctrl *ct 
	size_t nqnlen;

	int off;



	if(!(ctrl->quirks & NVME_QUIRK_IGNORE_DEV_SUBNQN)) {

		nqnlen = strnlen(id->subnqn, NVMF_NQN_SIZE);

		if (nqnlen > 0 && nqnlen < NVMF_NQN_SIZE) {

			strlcpy(subsys->subnqn, id->subnqn, NVMF_NQN_SIZE);
@@ -2181,6 +2182,7 @@ static void nvme_init_subnqn(struct nvme_subsystem *subsys, struct nvme_ctrl *ct 


		if (ctrl->vs >= NVME_VS(1, 2, 1))

			dev_warn(ctrl->device, "missing or invalid SUBNQN field.\n");

	}



	/* Generate a "fake" NQN per Figure 254 in NVMe 1.3 + ECN 001 */

	off = snprintf(subsys->subnqn, NVMF_NQN_SIZE,

drivers/nvme/host/nvme.h

+5 −0
Original line number Diff line number Diff line
@@ -90,6 +90,11 @@ enum nvme_quirks { 
	 * Set MEDIUM priority on SQ creation

	 */

	NVME_QUIRK_MEDIUM_PRIO_SQ		= (1 << 7),



	/*

	 * Ignore device provided subnqn.

	 */

	NVME_QUIRK_IGNORE_DEV_SUBNQN		= (1 << 8),

};



/*

drivers/nvme/host/pci.c

+2 −0
Original line number Diff line number Diff line
@@ -2971,6 +2971,8 @@ static const struct pci_device_id nvme_id_table[] = { 
	{ PCI_VDEVICE(INTEL, 0xf1a5),	/* Intel 600P/P3100 */

		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |

				NVME_QUIRK_MEDIUM_PRIO_SQ },

	{ PCI_VDEVICE(INTEL, 0xf1a6),	/* Intel 760p/Pro 7600p */

		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },

	{ PCI_VDEVICE(INTEL, 0x5845),	/* Qemu emulated controller */

		.driver_data = NVME_QUIRK_IDENTIFY_CNS, },

	{ PCI_DEVICE(0x1bb1, 0x0100),   /* Seagate Nytro Flash Storage */

CRA Git | Maintained and supported by SUSTech CRA and CCSE