Commit 3da584f5 authored by Keith Busch's avatar Keith Busch Committed by Christoph Hellwig
Browse files

nvme: pad fake subsys NQN vid and ssvid with zeros 



We need to preserve the leading zeros in the vid and ssvid when generating
a unique NQN. Truncating these may lead to naming collisions.

Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent c7055fd1

drivers/nvme/host/core.c

+1 −1
Original line number Diff line number Diff line
@@ -2184,7 +2184,7 @@ static void nvme_init_subnqn(struct nvme_subsystem *subsys, struct nvme_ctrl *ct 


	/* Generate a "fake" NQN per Figure 254 in NVMe 1.3 + ECN 001 */

	off = snprintf(subsys->subnqn, NVMF_NQN_SIZE,

			"nqn.2014.08.org.nvmexpress:%4x%4x",

			"nqn.2014.08.org.nvmexpress:%04x%04x",

			le16_to_cpu(id->vid), le16_to_cpu(id->ssvid));

	memcpy(subsys->subnqn + off, id->sn, sizeof(id->sn));

	off += sizeof(id->sn);

CRA Git | Maintained and supported by SUSTech CRA and CCSE