Commit 61ad36d4 authored Jul 09, 2018 by Chengguang Xu Committed by Ilya Dryomov Aug 02, 2018

ceph: return errors from posix_acl_equiv_mode() correctly



In order to return correct error code should replace variable ret
using err in error case.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent dfeb84d4

fs/ceph/acl.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -185,10 +185,10 @@ int ceph_pre_init_acls(struct inode dir, umode_t mode,
		return err;

		if (acl) {
		int ret = posix_acl_equiv_mode(acl, mode);
		if (ret < 0)
		err = posix_acl_equiv_mode(acl, mode);
		if (err < 0)
		goto out_err;
		if (ret == 0) {
		if (err == 0) {
		posix_acl_release(acl);
		acl = NULL;
		}

Admin message