Commit dfeb84d4 authored Jul 02, 2018 by Yan, Zheng Committed by Ilya Dryomov Aug 02, 2018

ceph: fix incorrect use of strncpy



GCC8 prints following warning:

 fs/ceph/mds_client.c:3683:2: warning: ‘strncpy’ output may be truncated
 copying 64 bytes from a string of length 64 [-Wstringop-truncation]

[ Change to strscpy() while at it. ]

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent b26c047b

fs/ceph/mds_client.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3644,8 +3644,8 @@ int ceph_mdsc_init(struct ceph_fs_client *fsc)
		init_rwsem(&mdsc->pool_perm_rwsem);
		mdsc->pool_perm_tree = RB_ROOT;

		strncpy(mdsc->nodename, utsname()->nodename,
		sizeof(mdsc->nodename) - 1);
		strscpy(mdsc->nodename, utsname()->nodename,
		sizeof(mdsc->nodename));
		return 0;
		}

Admin message