Commit 610600c8 authored Mar 23, 2015 by Sasha Levin Committed by David S. Miller Mar 24, 2015

tipc: validate length of sockaddr in connect() for dgram/rdm



Commit f2f8036e ("tipc: add support for connect() on dgram/rdm sockets")
hasn't validated user input length for the sockaddr structure which allows
a user to overwrite kernel memory with arbitrary input.

Fixes: f2f8036e ("tipc: add support for connect() on dgram/rdm sockets")
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0117ec19

net/tipc/socket.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1851,6 +1851,8 @@ static int tipc_connect(struct socket sock, struct sockaddr dest,
		if (dst->family == AF_UNSPEC) {
		memset(&tsk->remote, 0, sizeof(struct sockaddr_tipc));
		tsk->connected = 0;
		} else if (destlen != sizeof(struct sockaddr_tipc)) {
		res = -EINVAL;
		} else {
		memcpy(&tsk->remote, dest, destlen);
		tsk->connected = 1;

Admin message