Commit 604a7aeb authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

PM / OPP: Rename dev_pm_opp_register_put_opp_helper() 



The routine is named incorrectly since the first attempt as there is
nothing like a put_opp() helper. We wanted to unregister the set_opp()
helper here and so it should rather be named as
dev_pm_opp_unregister_set_opp_helper().

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 7978db34

drivers/opp/core.c

+3 −3
Original line number Diff line number Diff line
@@ -1476,13 +1476,13 @@ err: 
EXPORT_SYMBOL_GPL(dev_pm_opp_register_set_opp_helper);



/**

 * dev_pm_opp_register_put_opp_helper() - Releases resources blocked for

 * dev_pm_opp_unregister_set_opp_helper() - Releases resources blocked for

 *					   set_opp helper

 * @opp_table: OPP table returned from dev_pm_opp_register_set_opp_helper().

 *

 * Release resources blocked for platform specific set_opp helper.

 */

void dev_pm_opp_register_put_opp_helper(struct opp_table *opp_table)

void dev_pm_opp_unregister_set_opp_helper(struct opp_table *opp_table)

{

	if (!opp_table->set_opp) {

		pr_err("%s: Doesn't have custom set_opp helper set\n",
@@ -1497,7 +1497,7 @@ void dev_pm_opp_register_put_opp_helper(struct opp_table *opp_table) 


	dev_pm_opp_put_opp_table(opp_table);

}

EXPORT_SYMBOL_GPL(dev_pm_opp_register_put_opp_helper);

EXPORT_SYMBOL_GPL(dev_pm_opp_unregister_set_opp_helper);



/**

 * dev_pm_opp_add()  - Add an OPP table from a table definitions

include/linux/pm_opp.h

+2 −2
Original line number Diff line number Diff line
@@ -124,7 +124,7 @@ void dev_pm_opp_put_regulators(struct opp_table *opp_table); 
struct opp_table *dev_pm_opp_set_clkname(struct device *dev, const char * name);

void dev_pm_opp_put_clkname(struct opp_table *opp_table);

struct opp_table *dev_pm_opp_register_set_opp_helper(struct device *dev, int (*set_opp)(struct dev_pm_set_opp_data *data));

void dev_pm_opp_register_put_opp_helper(struct opp_table *opp_table);

void dev_pm_opp_unregister_set_opp_helper(struct opp_table *opp_table);

int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq);

int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, const struct cpumask *cpumask);

int dev_pm_opp_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask);
@@ -243,7 +243,7 @@ static inline struct opp_table *dev_pm_opp_register_set_opp_helper(struct device 
	return ERR_PTR(-ENOTSUPP);

}



static inline void dev_pm_opp_register_put_opp_helper(struct opp_table *opp_table) {}

static inline void dev_pm_opp_unregister_set_opp_helper(struct opp_table *opp_table) {}



static inline struct opp_table *dev_pm_opp_set_prop_name(struct device *dev, const char *name)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE