Commit 7978db34 authored Oct 04, 2017 by Tobias Jordan Committed by Rafael J. Wysocki Oct 11, 2017

PM / OPP: Add missing of_node_put(np)



The for_each_available_child_of_node() loop in _of_add_opp_table_v2()
doesn't drop the reference to "np" on errors. Fix that.

Fixes: 27465902 (PM / OPP: Add support to parse "operating-points-v2" bindings)
Cc: 4.3+ <stable@vger.kernel.org> # 4.3+
Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
[ VK: Improved commit log. ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 035ed072

drivers/opp/of.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -397,6 +397,7 @@ static int _of_add_opp_table_v2(struct device dev, struct device_node opp_np)
		dev_err(dev, "%s: Failed to add OPP, %d\n", __func__,
		ret);
		_dev_pm_opp_remove_table(opp_table, dev, false);
		of_node_put(np);
		goto put_opp_table;
		}
		}

Admin message