Commit 5f00a8d8 authored Nov 16, 2016 by Eric Dumazet Committed by David S. Miller Nov 16, 2016

cxgb4: do not call napi_hash_del()



Calling napi_hash_del() before netif_napi_del() is dangerous
if a synchronize_rcu() is not enforced before NAPI struct freeing.

Lets leave this detail to core networking stack and feel
more comfortable.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Hariprasad S <hariprasad@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ea339343

drivers/net/ethernet/chelsio/cxgb4/sge.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2951,7 +2951,6 @@ void free_rspq_fl(struct adapter adap, struct sge_rspq rq,
		rq->cntxt_id, fl_id, 0xffff);
		dma_free_coherent(adap->pdev_dev, (rq->size + 1) * rq->iqe_len,
		rq->desc, rq->phys_addr);
		napi_hash_del(&rq->napi);
		netif_napi_del(&rq->napi);
		rq->netdev = NULL;
		rq->cntxt_id = rq->abs_id = 0;

Admin message