Commit ea339343 authored Nov 16, 2016 by Eric Dumazet Committed by David S. Miller Nov 16, 2016

be2net: do not call napi_hash_del()



Calling napi_hash_del() before netif_napi_del() is dangerous
if a synchronize_rcu() is not enforced before NAPI struct freeing.

Lets leave this detail to core networking stack and feel
more comfortable.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Sathya Perla <sathya.perla@broadcom.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 963abe5c

drivers/net/ethernet/emulex/benet/be_main.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2813,7 +2813,6 @@ static void be_evt_queues_destroy(struct be_adapter *adapter)
		if (eqo->q.created) {
		be_eq_clean(eqo);
		be_cmd_q_destroy(adapter, &eqo->q, QTYPE_EQ);
		napi_hash_del(&eqo->napi);
		netif_napi_del(&eqo->napi);
		free_cpumask_var(eqo->affinity_mask);
		}

Admin message