Commit 5ee21245 authored Sep 19, 2009 by Julia Lawall Committed by David S. Miller Sep 22, 2009

drivers/net: remove duplicate structure field initialization

The definitions of vnet_ops and ehea_netdev_ops have initializations of a
local function and eth_change_mtu for their respective ndo_change_mtu
fields.  This change uses only the local function.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
  cocci.print_main(fld,p0)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 051b982b

drivers/net/ehea/ehea_main.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -3083,7 +3083,6 @@ static const struct net_device_ops ehea_netdev_ops = {
		.ndo_poll_controller = ehea_netpoll,
		#endif
		.ndo_get_stats = ehea_get_stats,
		.ndo_change_mtu = eth_change_mtu,
		.ndo_set_mac_address = ehea_set_mac_addr,
		.ndo_validate_addr = eth_validate_addr,
		.ndo_set_multicast_list = ehea_set_multicast_list,

drivers/net/sunvnet.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1016,7 +1016,6 @@ static const struct net_device_ops vnet_ops = {
		.ndo_open = vnet_open,
		.ndo_stop = vnet_close,
		.ndo_set_multicast_list = vnet_set_rx_mode,
		.ndo_change_mtu = eth_change_mtu,
		.ndo_set_mac_address = vnet_set_mac_addr,
		.ndo_validate_addr = eth_validate_addr,
		.ndo_tx_timeout = vnet_tx_timeout,

Admin message