Commit 051b982b authored Sep 19, 2009 by Kevin Cernekee Committed by David S. Miller Sep 22, 2009

kaweth: Fix memory leak in kaweth_control()



kaweth_control() never frees the buffer that it allocates for the USB
control message.  Test case:

while :; do ifconfig eth2 down ; ifconfig eth2 up ; done

This is a tiny buffer so it is a slow leak.  If you want to speed up the
process, you can change the allocation size to e.g. 16384 bytes, and it
will consume several megabytes within a few minutes.

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Acked-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6f41d12b

drivers/net/usb/kaweth.c

+11 −7

Original line number	Diff line number	Diff line
		@@ -263,6 +263,7 @@ static int kaweth_control(struct kaweth_device *kaweth,
		int timeout)
		{
		struct usb_ctrlrequest *dr;
		int retval;

		dbg("kaweth_control()");

		@@ -284,12 +285,15 @@ static int kaweth_control(struct kaweth_device *kaweth,
		dr->wIndex = cpu_to_le16(index);
		dr->wLength = cpu_to_le16(size);

		return kaweth_internal_control_msg(kaweth->dev,
		retval = kaweth_internal_control_msg(kaweth->dev,
		pipe,
		dr,
		data,
		size,
		timeout);

		kfree(dr);
		return retval;
		}

		/****************************************************************

Admin message