Commit 5ed9dc99 authored Nov 22, 2018 by Hangbin Liu Committed by David S. Miller Nov 23, 2018

team: no need to do team_notify_peers or team_mcast_rejoin when disabling port



team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin()
will send multicast join group message to notify peers. We should do this when
enabling/changed to a new port. But it doesn't make sense to do it when a port
is disabled.

On the other hand, when we set mcast_rejoin_count to 2, and do a failover,
team_port_disable() will increase mcast_rejoin.count_pending to 2 and then
team_port_enable() will increase mcast_rejoin.count_pending to 4. We will send
4 mcast rejoin messages at latest, which will make user confused. The same
with notify_peers.count.

Fix it by deleting team_notify_peers() and team_mcast_rejoin() in
team_port_disable().

Reported-by: Liang Li <liali@redhat.com>
Fixes: fc423ff0 ("team: add peer notification")
Fixes: 492b200e ("team: add support for sending multicast rejoins")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 18ba58e1

drivers/net/team/team.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -985,8 +985,6 @@ static void team_port_disable(struct team *team,
		team->en_port_count--;
		team_queue_override_port_del(team, port);
		team_adjust_ops(team);
		team_notify_peers(team);
		team_mcast_rejoin(team);
		team_lower_state_changed(port);
		}

Admin message