virtio-net: fail XDP set if guest csum is negotiated (18ba58e1) · Commits · 戴 / test

We don't support partial csumed packet since its metadata will be lost or incorrect during XDP processing. So fail the XDP set if guest_csum feature is negotiated. Fixes: ("virtio_net: Add XDP support") Reported-by:

Jesper Dangaard Brouer <brouer@redhat.com> Cc: Jesper Dangaard Brouer <brouer@redhat.com> Cc: Pavel Popa <pashinho1990@gmail.com> Cc: David Ahern <dsahern@gmail.com> Signed-off-by:

Jason Wang <jasowang@redhat.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/virtio_net.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -2361,8 +2361,9 @@ static int virtnet_xdp_set(struct net_device dev, struct bpf_prog prog,
		&& (virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO4) \|\|
		virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) \|\|
		virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) \|\|
		virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO))) {
		NL_SET_ERR_MSG_MOD(extack, "Can't set XDP while host is implementing LRO, disable LRO first");
		virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO) \|\|
		virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_CSUM))) {
		NL_SET_ERR_MSG_MOD(extack, "Can't set XDP while host is implementing LRO/CSUM, disable LRO/CSUM first");
		return -EOPNOTSUPP;
		}

Admin message