mtd: rawnand: marvell: Stop using nand_release() (5ecbba61) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-26-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/marvell_nand.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -2676,9 +2676,14 @@ static int marvell_nand_chip_init(struct device dev, struct marvell_nfc nfc,
		static void marvell_nand_chips_cleanup(struct marvell_nfc *nfc)
		{
		struct marvell_nand_chip entry, temp;
		struct nand_chip *chip;
		int ret;

		list_for_each_entry_safe(entry, temp, &nfc->chips, node) {
		nand_release(&entry->chip);
		chip = &entry->chip;
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		list_del(&entry->node);
		}
		}

Admin message